Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-281] port initialized with empty name #303

Merged
merged 14 commits into from
Apr 20, 2023
Merged

[Issue-281] port initialized with empty name #303

merged 14 commits into from
Apr 20, 2023

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Mar 8, 2023

Description & Motivation

Port of the Module can be initialized with an empty name.

Related Issue(s)

Fix #281

Testing

Added Logic name and definition name test

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

mkorbel1
mkorbel1 requested changes Mar 9, 2023
View reviewed changes
lib/src/module.dart Outdated Show resolved Hide resolved
lib/src/module.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Outdated Show resolved Hide resolved
@quekyj
Copy link
Contributor Author

quekyj commented Mar 13, 2023

I am not sure why the test failed but worked on my localhost.

@chykon
Copy link
Contributor

chykon commented Mar 13, 2023

I am not sure why the test failed but worked on my localhost.

As far as I understand, this issue should be fixed by this commit in this PR.

@mkorbel1
Copy link
Contributor

Yes that's right, sorry just merged #306 in.

mkorbel1
mkorbel1 requested changes Mar 13, 2023
View reviewed changes
lib/src/module.dart Outdated Show resolved Hide resolved
lib/src/module.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 March 17, 2023 09:09
mkorbel1
mkorbel1 requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just minor things

lib/src/module.dart Outdated Show resolved Hide resolved
test/logic_name_test.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 April 10, 2023 07:48
mkorbel1
mkorbel1 requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close, nice work!

lib/src/module.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkorbel1 mkorbel1 merged commit 7133115 into intel:main Apr 20, 2023
@quekyj quekyj deleted the 281-port-initialized-with-empty-name branch August 8, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port can be initialized with empty name
3 participants
@quekyj @chykon @mkorbel1