Fix long comment lines not caught by lint #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There are some comment lines in
logic_value.dartwhich are longer than 80 characters. They were not caught by the lint. Filed this issue on the linter (dart-lang/linter#4126), but for now just fix these ones.Also, fixing a race condition in the FSM tests that happened to fail in this PR that had to do with
tmp_testdirectory creation.Related Issue(s)
Linter bug: dart-lang/linter#4126
Testing
No, just comment changes, and linter doesn't work.
Backwards-compatibility
No
Documentation
Changes doc slightly since comment was reformatted.