Logic value test improvement and minor fixes #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Dec 1, 2023
|
Confirmed that the coverage has dramatically improved, great work! Thank you! Just the one comment then we can merge this. |
…ue to SV width expansion (intel#423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Added multiple testcases and made minor fixes in code to improve code coverage of
LogicValueand it's implementations (big, small, filled). All the code was not covered in existing tests.Related Issue(s)
#219
Testing
Added multiple testcases to test logical/bitwise operations and exception cases for
LogicValueand it's implementations (big, small, filled).Backwards-compatibility
No.
Documentation
No.