Improve Device-Side Random Uniform Filling by Reusing Host Implementation in SYCL #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
ClarkChin08
changed the title
tdeng5
requested review from
jiyang1011,
rolandschulz,
tdeng5,
Antonyvance and
taozha2
tdeng5
reviewed
Sep 17, 2025
| assert(false && "Not supported dtype"); | ||
| } | ||
| typename RealType<Element>::Type min, ///< lower bound for distribution | ||
| int bits = -1 |
There was a problem hiding this comment.
please add some comments for bits.
Done!
Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
tdeng5
approved these changes
Sep 17, 2025
taozha2
approved these changes
Sep 17, 2025
| int bits = -1 ///< If non-negative, specifies number of fractional bits that | ||
| /// are not truncated to zero. Permits reducing precision of | ||
| /// data. | ||
| ) { |
Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
leonling-lly
pushed a commit
to leonling-lly/cutlass-sycl
that referenced
this pull request
Sep 19, 2025
…ation in SYCL (intel#515) 1. Generates random data on the host and copies it to the device via syclcompat::memcpy, improving code reuse and supporting a broader range of element types. 2. An optional bits parameter to control fractional precision, which was not present in the original. --------- Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
sunjiweiswift
pushed a commit
to sunjiweiswift/cutlass-sycl
that referenced
this pull request
Sep 22, 2025
…ation in SYCL (intel#515) 1. Generates random data on the host and copies it to the device via syclcompat::memcpy, improving code reuse and supporting a broader range of element types. 2. An optional bits parameter to control fractional precision, which was not present in the original. --------- Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
nsingh-habana
pushed a commit
to nsingh-habana/cutlass-sycl
that referenced
this pull request
Sep 22, 2025
…ation in SYCL (intel#515) 1. Generates random data on the host and copies it to the device via syclcompat::memcpy, improving code reuse and supporting a broader range of element types. 2. An optional bits parameter to control fractional precision, which was not present in the original. --------- Signed-off-by: Chen, Xi2 <xi2.chen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.