Skip to content

Add dimension check to prevent out-of-bounds access in example 05_bmg_gemm_with_epilogue_splitk #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dimension check to prevent out-of-bounds access in example 05_bmg_gemm_with_epilogue_splitk #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/05_bmg_gemm_with_epilogues/05_bmg_gemm_with_epilogue_splitk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,10 @@ struct ExampleRunner {
auto D2 = std::vector<ElementOutput>(size(D2_shape));
compat::memcpy<ElementOutput>(D.data(), block_ref_D.get(), size(D_shape));
compat::wait();

if (N < NUM_HEAD * (NOPE_DIM + ROPE_DIM)) {
std::cout << "Error: n < num_head * (nope_dim + rope_dim). Please set a sufficiently large value for n. Skipping the check." << std::endl;
return true;
}
Comment on lines +222 to +224
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this parameters checking before launching the kernel?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, should we skip the validation of these out-of-range data or never let the kernel launching?

for (int l = 0; l < L; l++) {
for (int i = 0; i < M; i++) {
for (int j = 0; j < NUM_HEAD; j++) {
Expand Down