-
Notifications
You must be signed in to change notification settings - Fork 64
ARC not compiling #29
Comments
Yeah, this is a new problem that comes from an update in Zephyr tree. I don't think us tracking the tips of JerryScript and Zephyr randomly is very smart. In my "overlay" patch recently I added the ability for us to choose a particular commit for each to work with, and then we could advance that as we ensure compatibility to make our build more stable. @jimmy-huang, can you please add your fix here too? |
That is how Chromium works. It has a DEPS file and the tool, fetching with these known-to-work hashes Example: https://chromium.googlesource.com/chromium/src/+/lkgr/DEPS (not saying that we have to duplicate what they do - we can make something much simpler :-)) |
Yeah my version looks like this in repos.txt: So master can be replaced with ba55f154 and such. Actually, this is already in the tree, not part of the pending overlay patch. I think we'll just directly commit updates to those commit ids rather than submit PRs, to avoid confusion as to what code we're building against. We could even have jsrunner verify that you're on the right commits in your deps to avoid issues due to mismatches. |
Submitted pr #32 |
Still having issues
The text was updated successfully, but these errors were encountered: