This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[events] Fix mem leak of overwriting callback id #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one event callback was supposed to be created, but the line was moved to zjs_make_emitter so that it was created for each new emitter object. For tests that close and open sockets repeatedly, for example, this eventually caused the system to run out of memory. Fixes intel#1737 Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
jimmy-huang
reviewed
Feb 1, 2018
| #define DEFAULT_MAX_LISTENERS 10 | ||
|
|
||
| static jerry_value_t zjs_event_emitter_prototype = 0; | ||
| zjs_callback_id emit_id = -1; |
There was a problem hiding this comment.
making this global doesn't it mean that it can be overwritten with multiple events from different modules?
There was a problem hiding this comment.
It was already global... I just moved it up from down below because it's lifetime is now tied to that to that of the prototype defined just above.
However, it could probably be static...
|
+1 |
|
LGTM +1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one event callback was supposed to be created, but the line was
moved to zjs_make_emitter so that it was created for each new emitter
object. For tests that close and open sockets repeatedly, for example,
this eventually caused the system to run out of memory.
Fixes #1737
Signed-off-by: Geoff Gustafson geoff@linux.intel.com