KV stores must implement their own (de)serialization #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `IKeyValueStore` read/write method signatures have changed and no longer expect to receive or return `byte[]` (unless explicitly requested by a caller). - `KeyValueStore` no longer (de)serializes values by default but defines new helper methods that can be used in implementations to serialize values to JSON and compress the resulting bytes and to deserialize compressed JSON bytes. - `KeyValueStoreOptions` has a new `JsonOptions` property for defining default JSON options to use when (de)serializing values if no options are passed to the (de)serialize helper method. - `KeyValueStore<TOptions>` now seals the overridden `GetCompressionLevel()` method to always use the compression level from the `TOptions`. - Microsoft FASTER, file system and SQLite stores have been updated to use new (de)serialization helper methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IKeyValueStoreread/write method signatures have changed and no longer expect to receive or returnbyte[](unless explicitly requested by a caller).KeyValueStoreno longer (de)serializes values by default but defines new helper methods that can be used in implementations to serialize values to JSON and compress the resulting bytes and to deserialize compressed JSON bytes.KeyValueStoreOptionshas a newJsonOptionsproperty for defining default JSON options to use when (de)serializing values if no options are passed to the (de)serialize helper method.KeyValueStore<TOptions>now seals the overriddenGetCompressionLevel()method to always use the compression level from theTOptions.