COMP: Show the trait of an method #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
May 5, 2017
| @@ -17,6 +17,11 @@ object CompletionEngine { | |||
| const val KEYWORD_PRIORITY = 10.0 | |||
| } | |||
|
|
|||
| fun RsFunction.generateAppendTailText(): String { | |||
farodin91
force-pushed
the
autocomplete-trait
branch
from
15799cf
to
7589d94
Compare
alygin
reviewed
May 6, 2017
| @@ -35,6 +40,7 @@ fun RsCompositeElement.createLookupElement(scopeName: String): LookupElement { | |||
| is RsFunction -> base | |||
| .withTypeText(retType?.typeReference?.text ?: "()") | |||
| .withTailText(valueParameterList?.text?.replace("\\s+".toRegex(), " ") ?: "()") | |||
| .appendTailText(generateAppendTailText(), false) | |||
There was a problem hiding this comment.
Don't you think it'll look better with grayed = true? Won't distract from the function signature so much.
alygin
reviewed
May 6, 2017
| private fun RsFunction.generateAppendTailText(): String { | ||
| val trait = parentOfType<RsImplItem>()?.traitRef?.text ?: return "" | ||
| return " by $trait" | ||
| } |
There was a problem hiding this comment.
It looks more like a property. Could also be more compact:
private val RsFunction.extraTailText: String
get() = parentOfType<RsImplItem>()?.traitRef?.text?.let { " of $it" } ?: ""
farodin91
force-pushed
the
autocomplete-trait
branch
from
7589d94
to
19afb98
Compare
|
Thanks! |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190