Skip to content

RUN: Fix benches flag in cargo command completion #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

RUN: Fix benches flag in cargo command completion #6056

merged 1 commit into from
Sep 2, 2020

Conversation

avrong
Copy link
Member

@avrong avrong commented Sep 2, 2020 •
edited
Loading

According to the cargo docs it should have a --bench option, which we have with targetBench() to use a specific bench target and --benches to use all bench targets.

@mchernyavsky mchernyavsky added the fix Pull requests that fix some bug(s) label Sep 2, 2020
@mchernyavsky mchernyavsky self-assigned this Sep 2, 2020
@mchernyavsky mchernyavsky added this to the v131 milestone Sep 2, 2020
mchernyavsky
mchernyavsky approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 2, 2020

Build succeeded:

@bors bors bot merged commit 9a8dabe into intellij-rust:master Sep 2, 2020
@avrong avrong deleted the fix-benches-flag branch September 2, 2020 22:59
@mchernyavsky mchernyavsky mentioned this pull request Sep 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v131
Development

Successfully merging this pull request may close these issues.
2 participants
@avrong @mchernyavsky