Skip to content

Updated The Sync_Commands=True #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2021
Merged

Updated The Sync_Commands=True #165

merged 1 commit into from
May 14, 2021

Conversation

NeilShah2026
Copy link
Contributor

@NeilShah2026 NeilShah2026 commented May 2, 2021 •
edited
Loading

The Overide_Type is useless, id the commands won't work without the Sync Commands Aspect.

About this pull request

Description of the pr

Changes

What changes were made?

Checklist

  • [ X] I've checked this pull request runs on Python 3.6.X.
  • [ X] This fixes something in Issues.
    • Issue:
  • [X ] This adds something new.
  • There is/are breaking change(s).
  • [ X] (If required) Relevant documentation has been updated/added.
  • [ X] This is not a code change. (README, docs, etc.)

@NeilShah2026
Updated The Sync_Commands=True
40ce417 
The Overide_Type is useless, id the commands won't work without the Sync Commands Aspect.
LordOfPolls
LordOfPolls approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@LordOfPolls LordOfPolls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that override_type is useless in the context of examples (it has use elsewhere), ive never understood why its in the examples

@NeilShah2026
Copy link
Contributor Author

👍

@NeilShah2026
Copy link
Contributor Author

@LordOfPolls When will it be synced to the main README.md?

@eunwoo1104 eunwoo1104 added the documentation Improvements or additions to documentation label May 14, 2021
@eunwoo1104
Copy link
Contributor

Merging, thank you for contributing!

@eunwoo1104 eunwoo1104 merged commit 1429bb2 into interactions-py:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordOfPolls LordOfPolls LordOfPolls approved these changes

@eunwoo1104 eunwoo1104 eunwoo1104 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilShah2026 @eunwoo1104 @LordOfPolls