Automatically call get_cog_commands for all cogs #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LTGM! |
|
What's wrong? |
|
Looks good at first glance 👍 |
|
There is one problem: it can't handle cog reload. |
|
Okay then, new approach: overriding bot.add_cog and bot.remove_cog to register slash commands. This now makes it fully reload compatible. (docs not updated yet) |
eunwoo1104
suggested changes
Jan 16, 2021
Co-authored-by: eunwoo1104 <61371424+eunwoo1104@users.noreply.github.com>
Co-authored-by: eunwoo1104 <61371424+eunwoo1104@users.noreply.github.com>
eunwoo1104
approved these changes
Jan 16, 2021
|
Merging this pull request, thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Python 3.6.X.About this pull request
This removes the necessity to call
get_cog_commands()on each cog by automatically doing so inregister_all_commands(). It also displays a temporary warning that the call is no longer required. README and docs have been updated to reflect this.Also, first PR hype?