Implement PUT requests in auto_register #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this pull request
This implements PUT requests for registering commands when
auto_register
andauto_delete
are both true.This will reduce the amount of requests made to discord, only one per guild/global compared to one request for each command for each scope.
Changes
to_dict
toSlashCommand
function to get all commands into a dictionary, this reduces duplicated code fromregister_all_commands
andsync_all_commands
sync_all_commands
toSlashCommand
which uses PUT requests to update the commands.sync_all_commands
when bothauto_register
andauto_delete
areTrue
register_all_commands
whenauto_register
isTrue
andauto_delete
isn't.delete_unused_commands
whenauto_register
isTrue
andauto_delete
isn't.put_slash_commands
to httpChecklist
Python 3.6.X
.