New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$virus #174

Merged
merged 4 commits into from Mar 27, 2018

Conversation

Projects
None yet
3 participants
@gliechtenstein
Contributor

gliechtenstein commented Mar 27, 2018

No description provided.

gliechtenstein and others added some commits Jan 7, 2018

Virus: Plug-in system (#173)
* Implement Virus property
It allows the developer to make custom transformations to the genotype
before being parsed by Cell

* (wip) Fail when a mutation does not adhere to the API

* Add  feature as a plugin mechanism

* Add type by default after virus infection
This fixes the problem that the node was generated with a type
but the virus tried to override it to a div implicitly

* Fix missing semicolon

* Move virus infection up in the pipeline

Infecting in Genotype.build may be too late, as the $node is already
generated. This caused issues when writing viruses that changed the $type
of cells initially declared with "$type: 'input'".
This is also cleaner, as viruses act like dumb pre-processors or macro
expansions.

* Add Virus documentation

* Update VIRUS.md
@coveralls

This comment has been minimized.

coveralls commented Mar 27, 2018

Coverage Status

Coverage increased (+2.2%) to 86.047% when pulling 6ed18a0 on develop into 8150ca1 on master.

@gliechtenstein gliechtenstein merged commit cec7af0 into master Mar 27, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.2%) to 86.047%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment