feat(wallet-frontend): Grant list improvements #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: wallet/frontend
Tymmmy
changed the title
Tymmmy
changed the title
domin191013
reviewed
Feb 5, 2024
| @@ -57,7 +87,8 @@ type FinalizeInteractionParams = { | |||
| type FinalizeInteractionResponse = SuccessResponse | ErrorResponse | |||
|
|
|||
| interface GrantsService { | |||
| list: (cookies?: string) => Promise<ListGrantsResponse> | |||
| list: (args?: GrantListArgs, cookies?: string) => Promise<GrantsListResponse> | |||
There was a problem hiding this comment.
Maybe it could be good to rename list -> filter, listAll -> list?
There was a problem hiding this comment.
Well...it's not really filtering though, it is listing all in a specific pagination setup
dragosp1011
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
NOTE - the order of the grants will be latest Grant to oldest when we update rafiki on Testnet