Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add soft delete for transactions #1126

Merged
merged 10 commits into from
Feb 23, 2024

Conversation

domin191013
Copy link
Contributor

@github-actions github-actions bot added package: wallet/backend Wallet backend implementations type: source Source changes labels Feb 13, 2024
@domin191013 domin191013 self-assigned this Feb 13, 2024
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but wait for dragos approval

dragosp1011
dragosp1011 previously approved these changes Feb 23, 2024
@domin191013 domin191013 merged commit f02373a into main Feb 23, 2024
9 checks passed
@domin191013 domin191013 deleted the soft-delete-functionality-improvements branch February 23, 2024 16:45
devcer pushed a commit to devcer/testnet that referenced this pull request Mar 13, 2024
* - Add soft delete for transactions

* - Create separate migration for add delete flag in transaction constraint
- clear logs

* - Update all staled transactions related to soft deleted walletAddress

* - add active column to transactions
- add migration for active column

* - add deletedAT column to transactions instead of active

* fix: use join related instead of outer join

* fix: use left outer join

---------

Co-authored-by: Dragos <dragosh1011@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/backend Wallet backend implementations type: source Source changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft delete functionality improvements
4 participants