-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: developer keys improvement FE part #1145
Conversation
packages/wallet/frontend/src/components/dialogs/UploadKeysDialog.tsx
Outdated
Show resolved
Hide resolved
packages/wallet/frontend/src/components/dialogs/UploadKeysDialog.tsx
Outdated
Show resolved
Hide resolved
…ent"" This reverts commit 8dfaee7.
.get(`accounts${includeValues}`, { | ||
headers: { | ||
...(cookies ? { Cookie: cookies } : {}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/sindresorhus/ky?tab=readme-ov-file#searchparams
.get(`accounts${includeValues}`, { | |
headers: { | |
...(cookies ? { Cookie: cookies } : {}) | |
} | |
.get(`accounts`, { | |
searchParams, | |
headers: { | |
...(cookies ? { Cookie: cookies } : {}) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we will take this approach for searchParams
when listing accounts, can we update transactions.list
as well?
testnet/packages/wallet/frontend/src/lib/api/transaction.ts
Lines 70 to 78 in 54fe4d6
try { | |
const response = await httpClient | |
.get(`transactions?${params}`, { | |
retry: 0 | |
}) | |
.json<ListTransactionsResult>() | |
return response | |
} catch (error) { | |
return getError(error, 'Unable to fetch payment pointers.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a story ro change some stuff for transaction list, so I will add this there as well, and do it with that story.
#543
Context
Changes