Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: developer keys improvement FE part #1145

Merged
merged 15 commits into from
Feb 21, 2024
Merged

Conversation

Tymmmy
Copy link
Contributor

@Tymmmy Tymmmy commented Feb 20, 2024

Context

Changes

  • Added nickname to Keys
  • Possibility to upload keys
  • Organize by nickname

@Tymmmy Tymmmy linked an issue Feb 20, 2024 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations package: wallet/backend Wallet backend implementations type: test Improvements or additions to tests type: source Source changes labels Feb 20, 2024
@Tymmmy Tymmmy requested a review from dragosp1011 February 20, 2024 09:19
dragosp1011
dragosp1011 previously approved these changes Feb 20, 2024
@github-actions github-actions bot added package: boutique/backend Boutique backend implementations package: boutique/frontend Boutique frontend implementations labels Feb 20, 2024
@github-actions github-actions bot removed package: boutique/backend Boutique backend implementations package: boutique/frontend Boutique frontend implementations labels Feb 20, 2024
@Tymmmy Tymmmy changed the title 1112 developer keys improvement feat: 1112 developer keys improvement Feb 20, 2024
@Tymmmy Tymmmy changed the title feat: 1112 developer keys improvement feat: developer keys improvement FE part Feb 20, 2024
Comment on lines 126 to 129
.get(`accounts${includeValues}`, {
headers: {
...(cookies ? { Cookie: cookies } : {})
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sindresorhus/ky?tab=readme-ov-file#searchparams

Suggested change
.get(`accounts${includeValues}`, {
headers: {
...(cookies ? { Cookie: cookies } : {})
}
.get(`accounts`, {
searchParams,
headers: {
...(cookies ? { Cookie: cookies } : {})
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will take this approach for searchParams when listing accounts, can we update transactions.list as well?

try {
const response = await httpClient
.get(`transactions?${params}`, {
retry: 0
})
.json<ListTransactionsResult>()
return response
} catch (error) {
return getError(error, 'Unable to fetch payment pointers.')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a story ro change some stuff for transaction list, so I will add this there as well, and do it with that story.
#543

@github-actions github-actions bot removed package: wallet/backend Wallet backend implementations type: test Improvements or additions to tests labels Feb 21, 2024
@Tymmmy Tymmmy merged commit 18775af into main Feb 21, 2024
8 checks passed
@Tymmmy Tymmmy deleted the 1112-developer-keys-improvement branch February 21, 2024 12:59
devcer pushed a commit to devcer/testnet that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/frontend Wallet frontend implementations type: source Source changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Keys improvement
3 participants