Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added valid url check in callback url redirection #1213

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

devcer
Copy link
Contributor

@devcer devcer commented Mar 12, 2024

Context

Changes

Added an invalid URL check before the callback URL redirection

@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations type: source Source changes labels Mar 12, 2024
@devcer
Copy link
Contributor Author

devcer commented Mar 12, 2024

@raducristianpopa @Tymmmy The new URL(...).searchParams.set(...) already encode the URL, Hence encodeURIComponent is not needed in middleware. Otherwise, it is double encoding the already encoded URL, causing other URL issues. To verify this, you could open https://rafiki.money/transactions in incognito and you will see the encoded callback param in the URL.

@devcer devcer requested a review from Tymmmy March 13, 2024 10:34
@Tymmmy Tymmmy merged commit e1fdaf0 into interledger:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/frontend Wallet frontend implementations type: source Source changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rafiki.money vulnerability -> callbackURL parameter
2 participants