fix: start background processing only if the app started #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: wallet/backend
Tymmmy
reviewed
Mar 29, 2024
| await start(app) | ||
| await app.processResources() | ||
| } catch (e) { | ||
| console.log('Error on starting the app') |
There was a problem hiding this comment.
should we leave in console logs?
There was a problem hiding this comment.
yes, the app is not initialised on this step yet
| @@ -132,7 +132,7 @@ export class App { | |||
| .catch((err) => { | |||
| logger.error('Error while trying to process pending payments') | |||
| logger.error(err) | |||
| return true | |||
| return false | |||
There was a problem hiding this comment.
why is the return needed at all?
Is it so that the else branch gets executed in the following .then?
There was a problem hiding this comment.
yes, to setup the next execution
There was a problem hiding this comment.
with returning true, it was going inside the if with immediate execution and flooding the app with errors
beniaminmunteanu
approved these changes
Mar 29, 2024
Tymmmy
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes