Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1289): change name to "test wallet" #1290

Merged
merged 3 commits into from
Apr 17, 2024
Merged

fix(1289): change name to "test wallet" #1290

merged 3 commits into from
Apr 17, 2024

Conversation

AlexLakatos
Copy link
Member

@AlexLakatos AlexLakatos commented Apr 11, 2024 •
edited
Loading

@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations type: source Source changes labels Apr 11, 2024
@AlexLakatos AlexLakatos changed the title change name to "test wallet" fix: 1289 change name to "test wallet" Apr 11, 2024
@AlexLakatos AlexLakatos changed the title fix: 1289 change name to "test wallet" fix(1289): change name to "test wallet" Apr 11, 2024
raducristianpopa
raducristianpopa reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rename in the following places as well:

testnet/packages/wallet/frontend/src/pages/auth/signup.tsx

Lines 41 to 43 in 68d01b7

<h4 className="text-lg font-bold">
Welcome to Interledger Testnet
</h4>

testnet/packages/wallet/frontend/src/pages/auth/verify/[token].tsx

Lines 25 to 26 in 68d01b7

Your email has been verified. Continue to login to use Interledger
Testnet.

testnet/packages/wallet/backend/src/email/templates/verifyEmail.ts

Line 32 in 68d01b7

<p style="font-size:16px;line-height:28px;margin:16px 0;margin-bottom:30px">Welcome to Interledger Testnet. Before we get started, click on the link bellow to verify your email address.</p>

@AlexLakatos
Copy link
Member Author

AlexLakatos commented Apr 11, 2024 •
edited
Loading

😅 I played at developer @raducristianpopa , can you please make the rest of the changes?

@github-actions github-actions bot added the package: wallet/backend Wallet backend implementations label Apr 11, 2024
@dragosp1011 dragosp1011 merged commit 052f7b9 into main Apr 17, 2024
9 checks passed
@dragosp1011 dragosp1011 deleted the AlexLakatos-patch-1 branch April 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa left review comments

@Tymmmy Tymmmy Tymmmy approved these changes

Assignees
No one assigned
Labels
package: wallet/backend Wallet backend implementations package: wallet/frontend Wallet frontend implementations type: source Source changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change name to "Interledger Test Wallet"
4 participants
@AlexLakatos @raducristianpopa @Tymmmy @dragosp1011