feat: bring transaction response type into shared package #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domin191013
requested review from
dragosp1011,
beniaminmunteanu,
lengyel-arpad85 and
sanducb
github-actions
bot
added
package: wallet/frontend
beniaminmunteanu
previously approved these changes
Jun 13, 2024
dragosp1011
reviewed
Jun 14, 2024
# Conflicts: # packages/wallet/shared/src/types/index.ts
domin191013
force-pushed
the
shared-wallet-transaction
branch
from
b2030e1 to
e201b80
Compare
dragosp1011
reviewed
Jun 17, 2024
dragosp1011
reviewed
Jun 17, 2024
dragosp1011
reviewed
Jun 17, 2024
dragosp1011
reviewed
Jun 17, 2024
dragosp1011
reviewed
Jun 18, 2024
| @@ -323,7 +323,7 @@ const TransactionsPage: NextPageWithLayout<TransactionsPageProps> = ({ | |||
| /> | |||
| </Table.Cell> | |||
| <Table.Cell className="whitespace-nowrap"> | |||
| {formatDate({ date: trx.createdAt })} | |||
| {formatDate({ date: trx.createdAt.toString() })} | |||
There was a problem hiding this comment.
isn't it string already?
https://github.com/interledger/testnet/blob/main/packages/shared/backend/src/model.ts#L31
There was a problem hiding this comment.
The type of createdAt in the TransactionResponse interface is Date because it is implemented in the transaction model, but the frontend only accepts a string.
dragosp1011
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes