feat: fix duplicate uploaded key #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: wallet/backend
Tymmmy
reviewed
Jul 1, 2024
|
If the users have the same key (by any chance), will they be able to upload the same key? |
Tymmmy
approved these changes
Jul 2, 2024
|
@rico191013 please take a look at Radu's question and also on the story check the items that you solved. |
domin191013
commented
Jul 3, 2024
| @@ -91,7 +92,15 @@ export class WalletAddressKeyService implements IWalletAddressKeyService { | |||
| walletAddressId | |||
| } | |||
|
|
|||
| await WalletAddressKeys.query().insert(key) | |||
| try { | |||
| await WalletAddressKeys.query().insert(key) | |||
There was a problem hiding this comment.
@raducristianpopa For the sake of having a unique ID constraint for each key in the DB, every user can have one unique key for uploading, ensuring that others can't upload the same key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes