Skip to content

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Sep 26, 2024

Broadens the conditions under which the infinite scroller's results will be refreshed, to always include the initial page of results (even when multiple pages are being loaded in simultaneously).

Copy link

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-15 19:27 UTC

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (99a3dcf) to head (2f2dc44).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/collection-browser.ts 68.29% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   96.96%   96.19%   -0.77%     
==========================================
  Files          93       94       +1     
  Lines       15073    15801     +728     
  Branches      728      717      -11     
==========================================
+ Hits        14615    15200     +585     
- Misses        431      573     +142     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No apparent blockers. Code seems to make sense.

@latonv latonv force-pushed the webdev7022-blank-results-pane-bug branch from 5ccbde0 to 5c20a8c Compare November 15, 2024 19:07
@latonv latonv merged commit b45b065 into main Nov 15, 2024
1 of 2 checks passed
@latonv latonv deleted the webdev7022-blank-results-pane-bug branch November 15, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants