-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Search: Show correct Work's Edition in matching target language #448
Comments
Edition record is https://openlibrary.org/books/OL19166668M but the point is valid: facets should be usable to narrow the search results. |
relates to #412 |
This is also an issue when searching by ISBN if associated with more than one record. |
Ideally search results should match up with what the user searched for. In both the translated edition case and the ISBN case, the search result should be the edition. Similarly, hits on an author's AKA name should show the alias in the search result to make it obvious to the user what the connection is with their search. |
This is the same root problem as #342 |
Actually, after reexamining the issues. #2064 is closely related, but these two issues are seperate. Assigning @mekarpeles per slack discussions since he's assignee of #2064 |
I'm unsure what it looked like when the issue was filed, but is the edition search that exists now good enough here? Following the example link, clicking on the one returned work, and searching for "Qi er Tangmu Qiongsi de li shi" in the edition table search field results in a single edition in the table. |
@SouthGoingZax The edition table search is a big help with this issue and did not exist at the time the issue was created. Personally, I consider this solved. |
As I mentioned in my March 2018 comment, if the results don't correlate with the search phrase the user is going to be lost. If they just take a chance and click on the sole search result, they're shown a 1900 English edition, followed by 25 English and French editions. How in the world is that relevant to what they searched for? How are they supposed to know that they need to retype their query in a different search dialog (which is labelled in a foreign language)? If their search query matches an edition title, that (those) edition(s) should be at the top of the list. |
The "correct" solution is to fix search/Solr, but that's been a work in progress for years and shows no sign over ever implementing even basic features like diacritic folded searches let alone searching an entirely new entity type. Given that the work page shows the "best" edition, one short term solution would be to fix the algorithm so that it takes into account what's best for the OpenLibrary patrons, as opposed to what the Internet Archive leadership thinks will move their metrics. In this case, it's pretty clear that the searcher would consider https://openlibrary.org/books/OL19166668M to be the best edition, so I think this could be closed when that edition appears first when the user clicks through from the work in the search results page. |
At present the everything search for "Qi er Tangmu Qiongsi de li shi" finds OL45636W and shows OL7026657M as the first choice, which is clearly not correct. Only by a second search (for the specific edition of the work) is the intended OL19166668M shown. |
Ideally, if a search is done in a language:
It boils down to #2064 |
Edition-aware search is now enabled by default! This is fixed :) |
Searching for a translated edition title results in the correct work, but no way to easily locate the edition
Example: https://openlibrary.org/search?q=Qi+er+Tangmu+Qiongsi+de+li+shi
Correctly show the one work record for: The History of Tom Jones, a Foundling 176 editions
By Henry Fielding
but after clicking on the work, there is no easy way to locate that specific edition in the list of many. Readable / Borrowable English version are shown first.
This applies to any work with many (100s) of varied editions, not just translations.
The text was updated successfully, but these errors were encountered: