Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Search: Show correct Work's Edition in matching target language #448

Closed
hornc opened this issue Mar 15, 2017 · 14 comments
Closed
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 2 Important, as time permits. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@hornc
Copy link
Collaborator

hornc commented Mar 15, 2017

Searching for a translated edition title results in the correct work, but no way to easily locate the edition

Example: https://openlibrary.org/search?q=Qi+er+Tangmu+Qiongsi+de+li+shi

Correctly show the one work record for: The History of Tom Jones, a Foundling 176 editions
By Henry Fielding

but after clicking on the work, there is no easy way to locate that specific edition in the list of many. Readable / Borrowable English version are shown first.

This applies to any work with many (100s) of varied editions, not just translations.

@LeadSongDog
Copy link

Edition record is https://openlibrary.org/books/OL19166668M but the point is valid: facets should be usable to narrow the search results.

@hornc
Copy link
Collaborator Author

hornc commented Apr 26, 2017

relates to #412

@hornc hornc added the Theme: Search Issues related to search UI and backend. [managed] label May 8, 2017
@seabelis
Copy link
Collaborator

seabelis commented Feb 4, 2018

This is also an issue when searching by ISBN if associated with more than one record.

@tfmorris
Copy link
Contributor

tfmorris commented Mar 24, 2018

Ideally search results should match up with what the user searched for. In both the translated edition case and the ISBN case, the search result should be the edition. Similarly, hits on an author's AKA name should show the alias in the search result to make it obvious to the user what the connection is with their search.

@tfmorris
Copy link
Contributor

This is the same root problem as #342

@xayhewalo
Copy link
Collaborator

xayhewalo commented Oct 28, 2019

Solving #2064 will fix this issue, which has an assignee so I'm giving this issue a triage exception tag.

Actually, after reexamining the issues. #2064 is closely related, but these two issues are seperate. Assigning @mekarpeles per slack discussions since he's assignee of #2064

@tfmorris tfmorris added the Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] label Oct 28, 2019
@xayhewalo xayhewalo added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Priority: 2 Important, as time permits. [managed] State: Backlogged and removed GJ: triage exception labels Nov 4, 2019
@mekarpeles mekarpeles added the Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] label Dec 17, 2019
@SouthGoingZax
Copy link
Collaborator

SouthGoingZax commented Nov 21, 2020

I'm unsure what it looked like when the issue was filed, but is the edition search that exists now good enough here? Following the example link, clicking on the one returned work, and searching for "Qi er Tangmu Qiongsi de li shi" in the edition table search field results in a single edition in the table.

@seabelis
Copy link
Collaborator

@SouthGoingZax The edition table search is a big help with this issue and did not exist at the time the issue was created. Personally, I consider this solved.

@tfmorris
Copy link
Contributor

As I mentioned in my March 2018 comment, if the results don't correlate with the search phrase the user is going to be lost. If they just take a chance and click on the sole search result, they're shown a 1900 English edition, followed by 25 English and French editions. How in the world is that relevant to what they searched for? How are they supposed to know that they need to retype their query in a different search dialog (which is labelled in a foreign language)?

If their search query matches an edition title, that (those) edition(s) should be at the top of the list.

@SouthGoingZax
Copy link
Collaborator

Can someone elaborate on how this is different than #2064? Is this issue about the behavior of the work page after arriving from the search page, and #2064 is about the behavior of the search page?

@tfmorris
Copy link
Contributor

The "correct" solution is to fix search/Solr, but that's been a work in progress for years and shows no sign over ever implementing even basic features like diacritic folded searches let alone searching an entirely new entity type.

Given that the work page shows the "best" edition, one short term solution would be to fix the algorithm so that it takes into account what's best for the OpenLibrary patrons, as opposed to what the Internet Archive leadership thinks will move their metrics.

In this case, it's pretty clear that the searcher would consider https://openlibrary.org/books/OL19166668M to be the best edition, so I think this could be closed when that edition appears first when the user clicks through from the work in the search results page.

@LeadSongDog
Copy link

At present the everything search for "Qi er Tangmu Qiongsi de li shi" finds OL45636W and shows OL7026657M as the first choice, which is clearly not correct. Only by a second search (for the specific edition of the work) is the intended OL19166668M shown.

@mekarpeles mekarpeles added the Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] label Jan 23, 2021
@mekarpeles mekarpeles changed the title Searching for a translated edition title results in the correct work, but no way to easily locate the edition Language Search: Show correct Work's Edition in matching target language Jan 23, 2021
@mekarpeles
Copy link
Member

mekarpeles commented Jan 23, 2021

Ideally, if a search is done in a language:

  1. A Work should have a list of available [i.e. has ocaid] Editions (each with a language) in solr
  2. When one clicks the work, we should note ?language in the work redirect so we can choose the correct language
  3. We should use [1] to show preferably show the matching Edition + title information on the search works page

It boils down to #2064

@cdrini cdrini mentioned this issue Apr 4, 2022
63 tasks
@cdrini
Copy link
Collaborator

cdrini commented Dec 13, 2022

Edition-aware search is now enabled by default! This is fixed :)

@cdrini cdrini closed this as completed Dec 13, 2022
@cdrini cdrini assigned cdrini and unassigned mekarpeles Dec 13, 2022
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 2 Important, as time permits. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

8 participants