-
Notifications
You must be signed in to change notification settings - Fork 47
initial support for working together with language-server #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With both extension installed and active, if I disable the LS extension it requires a reload. Things then work as expected, with the ObjectScript extension taking over all the roles. But if I subsequently enable LS no reload is required and we get contributions from both extensions (e.g. double hovers).
Here's an idea for a solution:
- During
activate
gather the Disposables returned from each of theonXXX
andregisterXXX
calls that you make only when LS isn't active. - Use the
extensions.odDidChange
event to detect when LS gets activated. When this happens, dispose of all the Disposables you gathered during activation.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I will merge it immediately.
This PR fixes #