Skip to content

Different fixes in CI #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

Different fixes in CI #407

merged 2 commits into from
Oct 21, 2020

Conversation

daimor
Copy link
Member

@daimor daimor commented Oct 21, 2020

  • Resolves the issue with draft releases
  • Publish prebuild package
  • changes in artifacts

gjsjohnmurray
gjsjohnmurray approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the proof will come when we do the next release.

@daimor daimor merged commit 7f09815 into master Oct 21, 2020
@daimor daimor deleted the ci-update branch October 21, 2020 14:09
@gjsjohnmurray
Copy link
Contributor

Thanks @daimor. If you're willing to make the same changes in https://github.com/intersystems-community/intersystems-servermanager then I can easily do a two-stage release of that to publish the tweaked icon.

@gjsjohnmurray
Copy link
Contributor

The equivalent CI changes on Server Manager were verified by releasing 1.0.1 there. Thanks @daimor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daimor @gjsjohnmurray