Skip to content

Properly handle errors when previewing XML as UDL #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

Properly handle errors when previewing XML as UDL #907

merged 2 commits into from
Mar 31, 2022

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #906

@isc-bsaviano isc-bsaviano requested a review from daimor as a code owner March 29, 2022 15:06
gjsjohnmurray
gjsjohnmurray approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK based on code review.

@isc-bsaviano isc-bsaviano merged commit 8b188cf into intersystems-community:master Mar 31, 2022
@isc-bsaviano isc-bsaviano deleted the fix-906 branch March 31, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

@daimor daimor Awaiting requested review from daimor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preview XML as UDL not working
2 participants
@isc-bsaviano @gjsjohnmurray