-
Notifications
You must be signed in to change notification settings - Fork 9
Fix #23 and #24 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #23 and #24 #30
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 39.14% 38.98% -0.16%
==========================================
Files 14 14
Lines 1239 1244 +5
==========================================
Hits 485 485
- Misses 754 759 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! One note - please update module.xml to bump the minor version (as this is an enhancement), and please update CHANGELOG.md with notes on what's changed. (See existing content there for reference.)
Hi @isc-tleavitt, I've updated module.xml and added an entry into CHANGELOG.md. How does it look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Uh oh!
There was an error while loading. Please reload this page.