Skip to content

Fix #23 and #24 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Fix #23 and #24 #30

merged 11 commits into from
Jan 17, 2024

Conversation

isc-shuliu
Copy link
Contributor

@isc-shuliu isc-shuliu commented Jan 16, 2024

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9c2c65a) 39.14% compared to head (ea1a5f5) 38.98%.

Files Patch % Lines
cls/TestCoverage/Manager.cls 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   39.14%   38.98%   -0.16%     
==========================================
  Files          14       14              
  Lines        1239     1244       +5     
==========================================
  Hits          485      485              
- Misses        754      759       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-tleavitt isc-tleavitt self-requested a review January 17, 2024 13:58
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! One note - please update module.xml to bump the minor version (as this is an enhancement), and please update CHANGELOG.md with notes on what's changed. (See existing content there for reference.)

@isc-shuliu
Copy link
Contributor Author

Hi @isc-tleavitt, I've updated module.xml and added an entry into CHANGELOG.md. How does it look now?

@isc-tleavitt isc-tleavitt self-requested a review January 17, 2024 19:26
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@isc-tleavitt isc-tleavitt merged commit 0c2ff29 into intersystems:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants