Interoperability Process Tracking #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cesses code is identical to the * option
…bility processes after the production starts in %UnitTest.TestProduction test cases
…LogAssert is passed in by reference?
…bles, and added namespace to the query for processes
…bility too, tested that it still works on Profiler and using RunAllTests
isc-tleavitt
requested changes
Jul 3, 2024
There was a problem hiding this comment.
A few very minor comments.
Please also update CHANGELOG.md with a line on this in the "Added" section, referencing the issue number at the end - i.e.:
- Added a straightforward way to find and track coverage on all interoperability processes in the current namespace (#14)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 38.98% 38.71% -0.28%
==========================================
Files 14 14
Lines 1244 1258 +14
==========================================
+ Hits 485 487 +2
- Misses 759 771 +12 ☔ View full report in Codecov by Sentry. |
isc-tleavitt
previously approved these changes
Jul 5, 2024
|
Last thing - need to bump module.xml version to 3.2.0 |
isc-tleavitt
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an extra option for monitoring coverage by the current job as well as all interoperability processes.
Callable by setting tCoverageParams("ProcessIDs") = $ListBuild("Interop") and using RunTest() or by passing in $ListBuild("Interop") as the pPIDList parameter in RunAllTests()
Using "Interoperability" in place of $ListBuild("Interop") works as well.
Fixes #14