[fix] add nil checks to avoid panic when creating an OIR without a subscription #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
fix-nil-deref-on-oir-without-sub
branch
from
7303c23
to
aa805e4
Compare
barroco
approved these changes
May 24, 2024
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught this bug while testing the latest batch of dependency updates locally running the current monitoring qualifier.
This bug was introduced by #1035 (earlier DSS versions don't suffer from it). It seems I tested #1035 against an incorrect local version.
This PR addresses the issue while also adding a relevant unit test.
Test Plan
Tested locally using the
uss_qualifiersuccessfully, after having run against a failing version:With the exception of the message_signing scenario issue, all scenarios passed.