Skip to content

fix: conflict process global object in vDirective function #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix: conflict process global object in vDirective function #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vue-i18n-core/src/directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function getComposer(
export type TranslationDirective<T = HTMLElement> = ObjectDirective<T>

export function vTDirective(i18n: I18n): TranslationDirective<HTMLElement> {
const process = (binding: DirectiveBinding): [string, Composer] => {
const _process = (binding: DirectiveBinding): [string, Composer] => {
const { instance, modifiers, value } = binding
/* istanbul ignore if */
if (!instance || !instance.$) {
Expand All @@ -108,7 +108,7 @@ export function vTDirective(i18n: I18n): TranslationDirective<HTMLElement> {
}

const register = (el: HTMLElement, binding: DirectiveBinding): void => {
const [textContent, composer] = process(binding)
const [textContent, composer] = _process(binding)
if (inBrowser && i18n.global === composer) {
// global scope only
el.__i18nWatcher = watch(composer.locale, () => {
Expand Down Expand Up @@ -141,7 +141,7 @@ export function vTDirective(i18n: I18n): TranslationDirective<HTMLElement> {
}
}
const getSSRProps = (binding: DirectiveBinding) => {
const [textContent] = process(binding)
const [textContent] = _process(binding)
return { textContent }
}

Expand Down