Skip to content

fix: cannot hook at beforeUnmount/unmounted #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2021
Merged

fix: cannot hook at beforeUnmount/unmounted #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions packages/vue-i18n/src/mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getCurrentInstance } from 'vue'
import { getCurrentInstance, nextTick } from 'vue'
import { getLocaleMessages, SetPluralRulesSymbol } from './composer'
import { createVueI18n } from './legacy'
import { createI18nError, I18nErrorCodes } from './errors'
Expand Down Expand Up @@ -100,34 +100,36 @@ export function defineMixin(
}
},

beforeUnmount(): void {
unmounted(): void {
const instance = getCurrentInstance()
/* istanbul ignore if */
if (!instance) {
throw createI18nError(I18nErrorCodes.UNEXPECTED_ERROR)
}

/* istanbul ignore if */
if ((__DEV__ || __FEATURE_PROD_VUE_DEVTOOLS__) && !__NODE_JS__) {
if (this.__v_emitter) {
this.__v_emitter.off('*', addTimelineEvent)
delete this.__v_emitter
nextTick(() => {
/* istanbul ignore if */
if ((__DEV__ || __FEATURE_PROD_VUE_DEVTOOLS__) && !__NODE_JS__) {
if (this.__v_emitter) {
this.__v_emitter.off('*', addTimelineEvent)
delete this.__v_emitter
}
const _vueI18n = (this.$i18n as unknown) as VueI18nInternal
_vueI18n.__disableEmitter && _vueI18n.__disableEmitter()
delete this.$el.__VUE_I18N__
}
const _vueI18n = (this.$i18n as unknown) as VueI18nInternal
_vueI18n.__disableEmitter && _vueI18n.__disableEmitter()
delete this.$el.__VUE_I18N__
}

delete this.$t
delete this.$rt
delete this.$tc
delete this.$te
delete this.$d
delete this.$n
delete this.$tm
delete this.$t
delete this.$rt
delete this.$tc
delete this.$te
delete this.$d
delete this.$n
delete this.$tm

i18n.__deleteInstance(instance)
delete this.$i18n
i18n.__deleteInstance(instance)
delete this.$i18n
})
}
}
}
Expand Down
14 changes: 13 additions & 1 deletion packages/vue-i18n/test/i18n.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,19 @@ describe('slot reactivity', () => {
<i18n-t keypath='hello'/>
</SlotChild>
</div>
`
`,
created() {
// @ts-ignore
console.log('child created $t', this.$t)
},
beforeUnmount() {
// @ts-ignore
console.log('child beforeUnmount $t', this.$t)
},
unmounted() {
// @ts-ignore
console.log('child unmounted $t', this.$t)
}
}

const App = defineComponent({
Expand Down