Skip to content

improvement: deprecated __VUE_I18N_PROD_DEVTOOLS__ feature flag #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2021
Merged

improvement: deprecated __VUE_I18N_PROD_DEVTOOLS__ feature flag #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22d8947
breaking: deprecated __VUE_I18N_PROD_DEVTOOLS__ feature flag
kazupon Jul 17, 2021
45d7e23
updates
kazupon Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/guide/advanced/optimization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte

- `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
- `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
- `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)

:::warning NOTICE
Expand Down
1 change: 0 additions & 1 deletion packages/size-check-vue-i18n/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const config = {
__VUE_PROD_DEVTOOLS__: false,
__VUE_I18N_LEGACY_API__: false,
__VUE_I18N_FULL_INSTALL__: false,
__VUE_I18N_PROD_DEVTOOLS__: false,
__INTLIFY_PROD_DEVTOOLS__: false,
'process.env.NODE_ENV': JSON.stringify('production')
}),
Expand Down
1 change: 0 additions & 1 deletion packages/vue-i18n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte

- `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
- `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
- `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)

> NOTE: `__INTLIFY_PROD_DEVTOOLS__` flag is experimental, and `@intlify/devtools` is WIP yet.
Expand Down
5 changes: 0 additions & 5 deletions packages/vue-i18n/src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ export function initFeatureFlags(): void {
getGlobalThis().__VUE_I18N_LEGACY_API__ = true
}

if (typeof __FEATURE_PROD_VUE_DEVTOOLS__ !== 'boolean') {
needWarn = true
getGlobalThis().__VUE_I18N_PROD_DEVTOOLS__ = false
}

if (typeof __FEATURE_PROD_INTLIFY_DEVTOOLS__ !== 'boolean') {
getGlobalThis().__INTLIFY_PROD_DEVTOOLS__ = false
}
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ function createReplacePlugin(
? `__VUE_I18N_LEGACY_API__`
: true,
__FEATURE_PROD_VUE_DEVTOOLS__: isBundlerESMBuild
? `__VUE_I18N_PROD_DEVTOOLS__`
? `__VUE_PROD_DEVTOOLS__`
: false,
__FEATURE_PROD_INTLIFY_DEVTOOLS__: isBundlerESMBuild
? `__INTLIFY_PROD_DEVTOOLS__`
Expand Down