Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put required response_type parameter #160

Closed
wants to merge 1 commit into from

Conversation

brauliobo
Copy link

The required response_type parameter is missing (ref. http://tools.ietf.org/html/rfc6749#section-3.1.1)

@coveralls
Copy link

Coverage Status

Coverage decreased (-19.1%) when pulling d5039b0 on coletivoEITA:master into 6f5a8fe on intridea:master.

@sferik sferik force-pushed the master branch 2 times, most recently from 107c838 to 0ab3c21 Compare October 9, 2014 00:24
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 22340e4 on coletivoEITA:master into * on intridea:master*.

@pboling
Copy link
Member

pboling commented Mar 7, 2018

This is now handled in the current version of the code as follows:

    class AuthCode < Base
      # The required query parameters for the authorize URL
      #
      # @param [Hash] params additional query parameters
      def authorize_params(params = {})
        params.merge('response_type' => 'code', 'client_id' => @client.id)
      end

as per: https://tools.ietf.org/html/rfc6749#section-4.1.1

@pboling pboling closed this Mar 7, 2018
@pboling pboling added the stale Will be closed - to avoid zombie issues. label Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Will be closed - to avoid zombie issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants