Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serializers: review errors.py and decouple error abstraction from serialization #3

Closed
ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #23
Closed

serializers: review errors.py and decouple error abstraction from serialization #3

ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #23
Assignees

Comments

@ppanero
Copy link
Member

ppanero commented Jun 9, 2020

Error classes deal with abstracting a representation of the errors in the Flask views, so that they can be serialized in a second phase.

Right now they are coupled to a JSON serialization (in the class itself). However, this should be done by the make_error_response function in the resources.py (per resource class). Serializing according to the accepted mimetype.

Open Questions:

  • Should the error object implement Serializable? Should it be a different mixin "SerialiableError"?
  • How does the serialize_error and the make_error_response play with abort, application errors and handlers.
@ppanero ppanero changed the title Review errors.py and decouple error abstraction from serialization serializers: review errors.py and decouple error abstraction from serialization Jun 11, 2020
@ppanero ppanero mentioned this issue Jun 12, 2020
@ppanero ppanero self-assigned this Jun 15, 2020
@ppanero ppanero mentioned this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant