Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializers: resources should be independent of the request context #4

Closed
ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #19
Closed

serializers: resources should be independent of the request context #4

ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #19
Assignees
@ppanero

Comments

@ppanero
Copy link
Member

ppanero commented Jun 9, 2020

The resource class

flask-resources/flask_resources/resources.py

Line 20 in 0587e7e

class Resource(object):
uses the abort function to specify that is not implemented and it is just an interface. However, this make the resource aware of the request context. This should not be the case.

Maybe using a base error class for this, and just raising the error would do?
This was referenced Jun 9, 2020
Closed
Closed
Closed
@ppanero ppanero changed the title Resources should be independent of the request context serializers: resources should be independent of the request context Jun 11, 2020
@ppanero ppanero mentioned this issue Jun 15, 2020
Merged
@ppanero ppanero self-assigned this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppanero ppanero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serializer ppanero/flask-resources
1 participant
@ppanero