Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializers: clarify and implement default behaviour of the resource #9

Closed
ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #23
Closed

serializers: clarify and implement default behaviour of the resource #9

ppanero opened this issue Jun 9, 2020 · 0 comments · Fixed by #23
Assignees
@ppanero

Comments

@ppanero
Copy link
Member

ppanero commented Jun 9, 2020

Currently, the resource is answering with a forbidden 405 code using the abort function. See #4 for more information. However, this should be performed by the make_error_response function.

This one, along with:

  • load_item_from_request
  • make_list_response
  • make_item_response

Need clarification of what should be its default behaviour (it might simply be a NotImplemented for the latest 3, raising to the make_error_response.
@ppanero ppanero mentioned this issue Jun 11, 2020
Closed
@ppanero ppanero changed the title clarify and implement default behaviour of the resource serializers: clarify and implement default behaviour of the resource Jun 11, 2020
@ppanero ppanero mentioned this issue Jun 15, 2020
Merged
@ppanero ppanero self-assigned this Jun 15, 2020
@ppanero ppanero mentioned this issue Jun 15, 2020
Closed
@ppanero ppanero mentioned this issue Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppanero ppanero

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ppanero