Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ResultsTable component #337

Closed
zzacharo opened this issue May 10, 2019 · 1 comment
Closed

refactor: ResultsTable component #337

zzacharo opened this issue May 10, 2019 · 1 comment
Assignees
@topless
Labels
refactor Tech-frontend

Comments

@zzacharo
Copy link
Member

Here we need to check if the value is boolean and handle it differently as if the value of the column is false it returns - and also when is true the value is not displayed correctly.
@kpsherva kpsherva added bug Something isn't working Tech-frontend labels May 10, 2019
topless added a commit to topless/invenio-app-ils that referenced this issue Sep 23, 2019
@topless
bugs: results table
94052e8 
* fix in eitems now points to the right document_pid
* fix display of boolean values on table, inveniosoftware#337
topless added a commit to topless/invenio-app-ils that referenced this issue Sep 23, 2019
@topless
bugs: results table
7fbd661 
* fix in eitems now points to the right document_pid
* fix display of boolean values on table, inveniosoftware#337
@topless topless mentioned this issue Sep 23, 2019
Closed
@topless topless changed the title ui: ResultsTable component doesn't handle columns with boolean value correctly refactor: ResultsTable component Sep 23, 2019
@topless topless added refactor and removed bug Something isn't working labels Sep 23, 2019
@topless
Copy link
Member

topless commented Sep 23, 2019 •
edited
Loading

Instead of each list component to explicitly implement ResultsTable, with a custom formatter, create common components per model entity, LoansTable, DocumentTable which would encapsulate the formatters.

This issue should also address #407. We can provide two lists of properties to the about to be rendered table. A list with the required properties that are used for the internals of the components (i.e. ID), and a list of properties we want to display in the table.

  • Items
  • Loans
  • Document
  • DocumentRelations
  • DocumentRequests
  • EItems
  • Location
  • InternalLocation
  • Patrons
  • Series
  • Related

note: all the ResultLists have to align with *Table terminology -> ported to common concrete tables.

@topless topless added this to the Sprint 18 milestone Sep 23, 2019
@topless topless mentioned this issue Sep 23, 2019
Closed
@topless topless removed this from the Sprint 18 milestone Sep 25, 2019
@topless topless assigned topless and unassigned topless Sep 25, 2019
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
72d36bc 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
191c4c0 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
05fe9a3 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
05b49f5 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
41367ae 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
@topless topless removed their assignment Oct 3, 2019
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
21a9324 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 3, 2019
@topless
frontsite: grid of cards
65243a9 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses inveniosoftware#337
* closes inveniosoftware#528
zzacharo pushed a commit that referenced this issue Oct 4, 2019
@topless @zzacharo
frontsite: grid of cards
99f90de 
* focus on book cards
* combined MostRecentBooks, MostRecentEbooks and MostLoanedBooks to one component
* grid and list options for search kit layout
* fixes for links and iteration prop key missing
* several layout fixes
* removed unnecessary Result List
* addresses #337
* closes #528
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 11, 2019
@topless
backoffice: tables
7217f18 
* removed resultsList from PatronsSearch, DocumentRequestsSearch, EItemsSearch, ItemSearch, SeriesSearch, LoansSearch
* cleaned extra width for ID column
* fixed titles for documents
* adjustable header according to headerActions
* overview tables
* table content adjustment
* closes inveniosoftware#219, inveniosoftware#337
@topless topless closed this as completed Oct 11, 2019
@topless topless self-assigned this Oct 11, 2019
topless added a commit to topless/invenio-app-ils that referenced this issue Oct 14, 2019
@topless
backoffice: tables
cd2f9bb 
* removed resultsList from PatronsSearch, DocumentRequestsSearch, EItemsSearch, ItemSearch, SeriesSearch, LoansSearch
* cleaned extra width for ID column
* fixed titles for documents
* adjustable header according to headerActions
* overview tables
* table content adjustment
* closes inveniosoftware#219, inveniosoftware#337
kpsherva pushed a commit that referenced this issue Oct 14, 2019
@topless @kpsherva
backoffice: tables
179cc86 
* removed resultsList from PatronsSearch, DocumentRequestsSearch, EItemsSearch, ItemSearch, SeriesSearch, LoansSearch
* cleaned extra width for ID column
* fixed titles for documents
* adjustable header according to headerActions
* overview tables
* table content adjustment
* closes #219, #337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topless topless

Labels
refactor Tech-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugs: results table topless/invenio-app-ils
3 participants
@topless @zzacharo @kpsherva