resources: added management endpoints. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
force-pushed
the
add_user_management_rest_api
branch
from
dd0d990
to
37d5f07
Compare
alejandromumo
commented
Aug 16, 2023
| @@ -78,3 +82,39 @@ def avatar(self): | |||
| last_modified=avatar.last_modified, | |||
| max_age=avatar.max_age, | |||
| ) | |||
|
|
|||
| @request_view_args | |||
There was a problem hiding this comment.
We should add an error handler for lock errors.
This is useful for the caller to know why the moderation failed.
Since locks are not merged yet, I opened the PR without this handler. It can be added later on.
zzacharo
approved these changes
Aug 18, 2023
alejandromumo
commented
Aug 18, 2023
| @@ -156,6 +156,17 @@ def commit(self): | |||
| self.model.update(data) | |||
| return self | |||
|
|
|||
| @classmethod | |||
| def deactivate(cls, id_): | |||
There was a problem hiding this comment.
Added to invalidate the identity immediately, otherwise the users are deactivated and can still do things in the platform until they're logged off.
zzacharo
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes inveniosoftware/invenio-requests#344
We decided to add the endpoints in this deliverable since it was a minor effort for now.