global: Invenio 3.0 initial structure #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnielsen
force-pushed
the
next-invenio3
branch
4 times, most recently
from
73de31a
to
8dc7f89
Compare
| @@ -77,17 +87,25 @@ qthelp: | |||
| @echo | |||
| @echo "Build finished; now you can run "qcollectiongenerator" with the" \ | |||
| ".qhcp project file in $(BUILDDIR)/qthelp, like this:" | |||
| @echo "# qcollectiongenerator $(BUILDDIR)/qthelp/Invenio.qhcp" | |||
| @echo "# qcollectiongenerator $(BUILDDIR)/qthelp/cookiecutterproject_name.qhcp" | |||
There was a problem hiding this comment.
A cookiecutter leftover? I would be good to s/cookiecutterproject_name/invenio/g here and in several other places.
|
LGTM besides (1) the above-mentioned cookiecutter leftovers: $ git grep -Hni cookiecutter
docs/Makefile:90: @echo "# qcollectiongenerator $(BUILDDIR)/qthelp/cookiecutterproject_name.qhcp"
docs/Makefile:92: @echo "# assistant -collectionFile $(BUILDDIR)/qthelp/cookiecutterproject_name.qhc"
docs/Makefile:107: @echo "# mkdir -p $$HOME/.local/share/devhelp/cookiecutterproject_name"
docs/Makefile:108: @echo "# ln -s $(BUILDDIR)/devhelp $$HOME/.local/share/devhelp/cookiecutterproject_name"
docs/make.bat:130: echo.^> qcollectiongenerator %BUILDDIR%\qthelp\cookiecutterproject_name.qhcp
docs/make.bat:132: echo.^> assistant -collectionFile %BUILDDIR%\qthelp\cookiecutterproject_name.ghcand (2) Docker removal that we may partially still keep here to reproduce what python venv is doing. This may be important as the and we'll address this later. (E.g. the demo site could perhaps even be moved here under a new |
* Prepares code structure for Invenio 3 and aligns package structure with current package standards. * Removes all remaining legacy code from Invenio. * Removes docker scripts temporarily from Invenio. * Leaves current documentation in place. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
lnielsen
force-pushed
the
next-invenio3
branch
from
8dc7f89
to
c4c292f
Compare
|
@tiborsimko I've updated the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structure with current package standards.
Invenio-Demosite).
Signed-off-by: Lars Holm Nielsen lars.holm.nielsen@cern.ch