Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #1450

Closed

Conversation

lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Apr 14, 2022

  • upgrade dev dependencies
  • make main build command faster by parallelizing the work across formats

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@lifeiscontent
Copy link
Author

lifeiscontent commented Apr 14, 2022

side notes:

  • I noticed there's still a .travis.yml in the repo, I can delete it if you guys want.
  • should probably add Node 16 to GitHub Action as it's the LTS version

- upgrade dev dependencies
- make main build command faster by parallelizing the work across formats
@lifeiscontent
Copy link
Author

CC: @PodaruDragos

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #1450 (27c179f) into master (c69c369) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
- Coverage   99.85%   99.85%   -0.01%     
==========================================
  Files          53       53              
  Lines        1367     1361       -6     
  Branches      192      192              
==========================================
- Hits         1365     1359       -6     
  Partials        2        2              
Impacted Files Coverage Δ
src/resolution/instantiation.ts 98.30% <0.00%> (-0.03%) ⬇️
src/planning/planner.ts 100.00% <0.00%> (ø)
src/planning/request.ts 100.00% <0.00%> (ø)
src/resolution/resolver.ts 100.00% <0.00%> (ø)
src/utils/binding_utils.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69c369...27c179f. Read the comment docs.

@PodaruDragos
Copy link
Contributor

PodaruDragos commented Apr 16, 2022

@lifeiscontent LGTM, thanks.

@jakehamtexas what do you think ?

Edit: re-running this again has failed. there are still some problems in the CI

@dcavanagh
Copy link
Member

Maybe revert Sinon?

package.json Outdated Show resolved Hide resolved
@lifeiscontent
Copy link
Author

@dcavanagh didn't seem to do it, any other ideas?

@notaphplover
Copy link
Member

Such a shame we never merged this. Fortunately dependencies are sort of updated these days. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants