Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #136 #147

Merged
merged 15 commits into from
Apr 4, 2016
Merged

Implements #136 #147

merged 15 commits into from
Apr 4, 2016

Conversation

remojansen
Copy link
Member

Description

#136

Related Issue

#136

Motivation and Context

We have a new API that supports classes:

classes

Interfaces (string literals):

interfaces

Interfaces (Symbols):

symbols

Read to learn more #136

How Has This Been Tested?

Unit tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @adidahiya, @PeterDaveHello and @mikaturunen to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1de1e68 on remojansen:master into 3bc34e3 on inversify:master.

@remojansen remojansen merged commit 8764a87 into inversify:master Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants