Fix @targetName() signature on TypeScript 5
#1561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
commented
Mar 9, 2024
| @@ -3,7 +3,7 @@ import { Metadata } from '../planning/metadata'; | |||
| import { tagParameter, DecoratorTarget } from './decorator_utils'; | |||
|
|
|||
| function targetName(name: string) { | |||
| return function (target: DecoratorTarget, targetKey: string, index: number) { | |||
| return function (target: DecoratorTarget, targetKey: string | undefined, index: number) { | |||
There was a problem hiding this comment.
Could even be this, and would still work
Suggested change
| return function (target: DecoratorTarget, targetKey: string | undefined, index: number) { | |
| return function (target: DecoratorTarget, targetKey: undefined, index: number) { |
|
...is anyone in here? |
|
Hey @gustavohenke , I fixed it in #1586, I'll close this PR since the issue should be solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title. Basically just makes it accept an undefined value for
targetKey, which stops TypeScript from complaining about it.Related Issue
#1556
Motivation and Context
I want to upgrade Typescript to v5 and use
@targetName().See https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#more-accurate-type-checking-for-parameter-decorators-in-constructors-under-experimentaldecorators
How Has This Been Tested?
Not a functional change, but rather a type change. That said,
npm teststill passes.Furthermore, TypeScript v5.x.x no longer shows errors when using
@targetName().Types of changes
Checklist: