feat: PlausibleHQ support #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
Closed
Salakar
reviewed
Oct 25, 2022
docs/configuration.mdx
Outdated
|
|
||
| | Key | Type | Default | | ||
| | -------------------- | -------- | ------- | | ||
| | `plausibleAnalytics` | `string` | | |
There was a problem hiding this comment.
shouldn't this be a bool, the value of the string is never used?
Salakar
reviewed
Oct 25, 2022
| @@ -85,6 +87,8 @@ export interface ConfigWithLocales { | |||
| experimentalMath: boolean; | |||
| // automatically infer next/previous | |||
| automaticallyInferNextPrevious: boolean; | |||
| // Adds Plausible Analytics to your documentation pages. | |||
| plausibleAnalytics: string; | |||
There was a problem hiding this comment.
shouldn't this be a bool, the value of the string is never used?
Salakar
reviewed
Oct 25, 2022
packages/server/src/types.ts
Outdated
| @@ -137,6 +141,8 @@ export interface OutputConfig { | |||
| experimentalMath: boolean; | |||
| // automatically infer next/previous | |||
| automaticallyInferNextPrevious: boolean; | |||
| // Adds Plausible Analytics to your documentation pages. | |||
| plausibleAnalytics: string; | |||
There was a problem hiding this comment.
shouldn't this be a bool, the value of the string is never used?
Salakar
reviewed
Oct 25, 2022
| @@ -158,6 +164,7 @@ export const defaultConfig: OutputConfig = { | |||
| experimentalCodehike: false, | |||
| experimentalMath: false, | |||
| automaticallyInferNextPrevious: true, | |||
| plausibleAnalytics: '', | |||
There was a problem hiding this comment.
shouldn't this be a bool, the value of the string is never used?
Salakar
reviewed
Oct 25, 2022
docs/configuration.mdx
Outdated
|
|
||
| ### `plausibleAnalytics` | ||
|
|
||
| If provided, Plausible Analytics will be added to all of your documentation pages. |
There was a problem hiding this comment.
Maybe note that this only works for custom domains?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created this new PR with formatted code. Will review and manual test this.