This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Updates to reflect new React Native MainApplication code #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getPackages method has changed with the latest version of React Native to not include the default firebase package and requires a different way of adding module packages. This updates the documentation for Auth to reflect this. If this PR is approved, I can make this same change across other modules.
|
|
mikehardy
suggested changes
Aug 17, 2019
mikehardy
suggested changes
Aug 17, 2019
|
almost perfect :-), then can be clone-stamped photoshop style to the others |
Co-Authored-By: Mike Hardy <github@mikehardy.net>
|
Done! |
mikehardy
approved these changes
Aug 18, 2019
|
should be live now! |
|
Awesome! Glad to contribute since this project (and excellent documentation) has been such a help to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getPackages method has changed with the latest version of React Native to not include the default firebase package and requires a different way of adding module packages. This updates the documentation for Auth to reflect this. If this PR is approved, I can make this same change across other modules.