refactor(ci): testing app with new Jet (#7874)

Author: Salakar

.github/workflows/scripts/adb_all_emulators.sh

@@ -1,10 +1,10 @@
 #!/bin/bash
 echo "Running $1 on all running emulators..."
-devices=`adb devices`
+devices=`$ANDROID_HOME/platform-tools/adb devices`
 
 for device in $devices; do
     if [[ "$device" =~ "emulator-" ]]; then
-      adb -s $device $1
+      $ANDROID_HOME/platform-tools/adb -s $device $1
     fi    
 done    
 echo "All Done."

.github/workflows/tests_e2e_android.yml

@@ -28,7 +28,7 @@ concurrency:
 jobs:
   android:
     name: Android
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-l
     timeout-minutes: 90
     strategy:
       fail-fast: false
@@ -46,7 +46,7 @@ jobs:
         iteration: [0]
     env:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-      EMULATOR_COMMAND: "-avd TestingAVD -noaudio -gpu swiftshader_indirect -camera-back none -no-snapshot -no-window -no-boot-anim -nojni -memory 2048 -timezone 'Europe/London' -cores 2"
+      EMULATOR_COMMAND: "-avd TestingAVD -noaudio -gpu swiftshader_indirect -camera-back none -no-snapshot -no-window -no-boot-anim -nojni -memory 4096 -timezone 'Europe/London' -cores 4"
       EMULATOR_EXECUTABLE: qemu-system-x86_64-headless
     steps:
       - name: Liberate disk space

.github/workflows/tests_e2e_ios.yml

@@ -27,7 +27,7 @@ concurrency:
 jobs:
   ios:
     name: iOS
-    runs-on: macos-14
+    runs-on: macos-14-xlarge
     # TODO matrix across APIs, at least 11 and 15 (lowest to highest)
     timeout-minutes: 100
     env:
@@ -78,7 +78,7 @@ jobs:
       - uses: hendrikmuhs/ccache-action@v1
         name: Xcode Compile Cache
         with:
-          key: ${{ runner.os }}-v2 # makes a unique key w/related restore key internally
+          key: ${{ runner.os }}-v3 # makes a unique key w/related restore key internally
           create-symlink: true
           max-size: 1500M
 
@@ -108,8 +108,8 @@ jobs:
         id: pods-cache
         with:
           path: tests/ios/Pods
-          key: ${{ runner.os }}-pods-v2-${{ hashFiles('tests/ios/Podfile.lock') }}
-          restore-keys: ${{ runner.os }}-pods-v2
+          key: ${{ runner.os }}-pods-v3-${{ hashFiles('tests/ios/Podfile.lock') }}
+          restore-keys: ${{ runner.os }}-pods-v3
 
       - name: Pod Install
         uses: nick-fields/retry@v3

package.json

@@ -3,6 +3,7 @@
   "private": true,
   "scripts": {
     "version": "node ./scripts/version.js",
+    "prepare": "patch-package",
     "lerna:prepare": "lerna run prepare",
     "lerna:clean": "lerna clean",
     "build:all:clean": "lerna run build:clean",
@@ -32,15 +33,13 @@
     "tests:android:build:windows": "cd tests && yarn detox build --configuration android.emu.debug.windows",
     "tests:android:build-release": "cd tests && yarn detox build --configuration android.emu.release",
     "tests:android:test": "yarn tests:android:emulator:forward && cd tests && yarn detox test --configuration android.emu.debug",
-    "tests:android:test-no-compat": "yarn tests:android:emulator:forward && cd tests && SKIP_COMPAT_TESTS=true yarn detox test --configuration android.emu.debug",
     "tests:android:test:windows": "cd tests && yarn detox test --configuration android.emu.debug",
     "tests:android:test:debug": "yarn tests:android:emulator:forward && cd tests && yarn detox test --configuration android.emu.debug --inspect",
     "tests:android:test-reuse": "yarn tests:android:emulator:forward && cd tests && yarn detox test --configuration android.emu.debug --reuse",
-    "tests:android:test-reuse-no-compat": "yarn tests:android:emulator:forward && cd tests && SKIP_COMPAT_TESTS=true yarn detox test --configuration android.emu.debug --reuse",
     "tests:android:test-cover": "yarn tests:android:emulator:forward && cd tests && ./node_modules/.bin/nyc yarn detox test --configuration android.emu.debug",
     "tests:android:test-cover-reuse": "yarn tests:android:emulator:forward && cd tests && ./node_modules/.bin/nyc yarn detox test --configuration android.emu.debug --reuse",
     "tests:android:test:jacoco-report": "cd tests/android && ./gradlew jacocoAndroidTestReport",
-    "tests:android:emulator:forward": ".github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:8081 tcp:8081'",
+    "tests:android:emulator:forward": ".github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:8081 tcp:8081' && .github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:8090 tcp:8090' && .github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:8080 tcp:8080' && .github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:9099 tcp:9099' && .github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:9000 tcp:9000' && .github/workflows/scripts/adb_all_emulators.sh 'reverse tcp:9199 tcp:9199'",
     "tests:ios:build": "cd tests && yarn detox build --configuration ios.sim.debug",
     "tests:ios:build-release": "cd tests && yarn detox build --configuration ios.sim.release",
     "tests:ios:test": "cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 yarn detox test --configuration ios.sim.debug --loglevel warn",
@@ -81,6 +80,7 @@
     "inquirer": "^8.2.6",
     "jest": "^29.7.0",
     "lerna": "^8.1.4",
+    "patch-package": "^8.0.0",
     "prettier": "^3.3.2",
     "regenerator-transform": "^0.15.2",
     "rimraf": "^5.0.7",

packages/app-check/e2e/appcheck.e2e.js

@@ -15,7 +15,45 @@
  *
  */
 
-const jwt = require('jsonwebtoken');
+function decodeJWT(token) {
+  // Split the token into its parts
+  const parts = token.split('.');
+
+  if (parts.length !== 3) {
+    throw new Error('Invalid token format');
+  }
+
+  // Decode the base64 URL parts
+  const base64UrlDecode = str => {
+    let base64 = str.replace(/-/g, '+').replace(/_/g, '/');
+    switch (base64.length % 4) {
+      case 0:
+        break;
+      case 2:
+        base64 += '==';
+        break;
+      case 3:
+        base64 += '=';
+        break;
+      default:
+        throw new Error('Invalid base64 string');
+    }
+
+    return decodeURIComponent(
+      atob(base64)
+        .split('')
+        .map(function (c) {
+          return '%' + ('00' + c.charCodeAt(0).toString(16)).slice(-2);
+        })
+        .join(''),
+    );
+  };
+
+  // Decode the payload
+  const payload = JSON.parse(base64UrlDecode(parts[1]));
+
+  return payload;
+}
 
 describe('appCheck() modular', function () {
   describe('firebase v8 compatibility', function () {
@@ -48,7 +86,7 @@ describe('appCheck() modular', function () {
       // it relies on token auto refresh being left false for local tests where the app is reused, since it is persistent
       // but in CI it's fresh every time and would be true if not overridden in Info.plist
       it('should configure token auto refresh in Info.plist on ios', async function () {
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           const tokenRefresh =
             await NativeModules.RNFBAppCheckModule.isTokenAutoRefreshEnabled('[DEFAULT]');
           tokenRefresh.should.equal(false);
@@ -63,14 +101,14 @@ describe('appCheck() modular', function () {
         firebase.appCheck().setTokenAutoRefreshEnabled(false);
 
         // Only iOS lets us assert on this unfortunately, other platforms have no accessor
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           let tokenRefresh =
             await NativeModules.RNFBAppCheckModule.isTokenAutoRefreshEnabled('[DEFAULT]');
           tokenRefresh.should.equal(false);
         }
         firebase.appCheck().setTokenAutoRefreshEnabled(true);
         // Only iOS lets us assert on this unfortunately, other platforms have no accessor
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           tokenRefresh =
             await NativeModules.RNFBAppCheckModule.isTokenAutoRefreshEnabled('[DEFAULT]');
           tokenRefresh.should.equal(true);
@@ -82,7 +120,7 @@ describe('appCheck() modular', function () {
       it('token fetch attempt with configured debug token should work', async function () {
         const { token } = await firebase.appCheck().getToken(true);
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -97,7 +135,7 @@ describe('appCheck() modular', function () {
         // TODO sometimes fails on android https://github.com/firebase/firebase-android-sdk/issues/2954
         const { token: token2 } = await firebase.appCheck().getToken(true);
         token2.should.not.equal('');
-        const decodedToken2 = jwt.decode(token2);
+        const decodedToken2 = decodeJWT(token2);
         decodedToken2.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken2.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -152,7 +190,7 @@ describe('appCheck() modular', function () {
 
         const { token } = await firebase.appCheck().getToken(true);
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -166,7 +204,7 @@ describe('appCheck() modular', function () {
       it('limited use token fetch attempt with configured debug token should work', async function () {
         const { token } = await firebase.appCheck().getLimitedUseToken();
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -240,14 +278,14 @@ describe('appCheck() modular', function () {
 
         setTokenAutoRefreshEnabled(appCheckInstance, false);
         // Only iOS lets us assert on this unfortunately, other platforms have no accessor
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           let tokenRefresh =
             await NativeModules.RNFBAppCheckModule.isTokenAutoRefreshEnabled('[DEFAULT]');
           tokenRefresh.should.equal(false);
         }
         setTokenAutoRefreshEnabled(appCheckInstance, true);
         // Only iOS lets us assert on this unfortunately, other platforms have no accessor
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           tokenRefresh =
             await NativeModules.RNFBAppCheckModule.isTokenAutoRefreshEnabled('[DEFAULT]');
           tokenRefresh.should.equal(true);
@@ -261,7 +299,7 @@ describe('appCheck() modular', function () {
 
         const { token } = await getToken(appCheckInstance, true);
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -276,7 +314,7 @@ describe('appCheck() modular', function () {
         // TODO sometimes fails on android https://github.com/firebase/firebase-android-sdk/issues/2954
         const { token: token2 } = await getToken(appCheckInstance, true);
         token2.should.not.equal('');
-        const decodedToken2 = jwt.decode(token2);
+        const decodedToken2 = decodeJWT(token2);
         decodedToken2.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken2.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -335,7 +373,7 @@ describe('appCheck() modular', function () {
 
         const { token } = await getToken(instance2, true);
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(
@@ -371,7 +409,7 @@ describe('appCheck() modular', function () {
 
         const { token } = await getLimitedUseToken(appCheckInstance);
         token.should.not.equal('');
-        const decodedToken = jwt.decode(token);
+        const decodedToken = decodeJWT(token);
         decodedToken.aud[1].should.equal('projects/react-native-firebase-testing');
         if (decodedToken.exp * 1000 < Date.now()) {
           return Promise.reject(

packages/app-distribution/e2e/app-distribution.e2e.js

@@ -25,7 +25,7 @@ describe('appDistribution()', function () {
 
     describe('isTesterSignedIn()', function () {
       it('checks if a tester is signed in', async function () {
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await firebase.appDistribution().isTesterSignedIn();
         } else {
           this.skip();
@@ -35,7 +35,7 @@ describe('appDistribution()', function () {
     // Requires a valid google account logged in on device and associated with iOS testing app
     xdescribe('signInTester()', function () {
       it('signs a tester in', async function () {
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await firebase.appDistribution().signInTester();
         } else {
           this.skip();
@@ -45,7 +45,7 @@ describe('appDistribution()', function () {
 
     describe('signOutTester()', function () {
       it('signs out a tester', async function () {
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await firebase.appDistribution().signOutTester();
         } else {
           this.skip();
@@ -56,7 +56,7 @@ describe('appDistribution()', function () {
     // plus a new IPA file uploaded
     xdescribe('checkForUpdate()', function () {
       it('checks for an update', async function () {
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await firebase.appDistribution().checkForUpdate();
         } else {
           this.skip();
@@ -78,7 +78,7 @@ describe('appDistribution()', function () {
       it('checks if a tester is signed in', async function () {
         const { getAppDistribution, isTesterSignedIn } = appDistributionModular;
         const appDistribution = getAppDistribution();
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await isTesterSignedIn(appDistribution);
         } else {
           this.skip();
@@ -90,7 +90,7 @@ describe('appDistribution()', function () {
       it('signs a tester in', async function () {
         const { getAppDistribution, signInTester } = appDistributionModular;
         const appDistribution = getAppDistribution();
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await signInTester(appDistribution);
         } else {
           this.skip();
@@ -102,7 +102,7 @@ describe('appDistribution()', function () {
       it('signs out a tester', async function () {
         const { getAppDistribution, signOutTester } = appDistributionModular;
         const appDistribution = getAppDistribution();
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await signOutTester(appDistribution);
         } else {
           this.skip();
@@ -115,7 +115,7 @@ describe('appDistribution()', function () {
       it('checks for an update', async function () {
         const { getAppDistribution, checkForUpdate } = appDistributionModular;
         const appDistribution = getAppDistribution();
-        if (device.getPlatform() === 'ios') {
+        if (Platform.ios) {
           await checkForUpdate(appDistribution);
         } else {
           this.skip();

packages/app/e2e/helpers.js

@@ -3,9 +3,8 @@ exports.getE2eTestProject = function getE2eTestProject() {
 };
 
 exports.getE2eEmulatorHost = function getE2eEmulatorHost() {
-  // Note that in most package implementations involving the emulator, we re-write
-  // localhost and 127.0.0.1 on Android to 10.0.2.2 (the Android emulator host interface)
-  // But this specific code is executing in the host context even during E2E test.
-  // So no re-write is necessary here.
+  if (Platform.android) {
+    return '10.0.2.2';
+  }
   return '127.0.0.1';
 };

packages/app/e2e/utilsStatics.e2e.js

@@ -21,7 +21,7 @@ describe('utils()', function () {
   describe('statics', function () {
     it('provides native path strings', function () {
       firebase.utils.FilePath.should.be.an.Object();
-      if (device.getPlatform() === 'ios') {
+      if (Platform.ios) {
         firebase.utils.FilePath.MAIN_BUNDLE.should.be.a.String();
       } else {
         should.equal(firebase.utils.FilePath.MAIN_BUNDLE, null);
@@ -31,20 +31,14 @@ describe('utils()', function () {
       firebase.utils.FilePath.DOCUMENT_DIRECTORY.should.be.a.String();
 
       // Even on android it may be null, skip if so
-      if (
-        device.getPlatform() === 'android' &&
-        firebase.utils.FilePath.EXTERNAL_DIRECTORY !== null
-      ) {
+      if (Platform.android && firebase.utils.FilePath.EXTERNAL_DIRECTORY !== null) {
         firebase.utils.FilePath.EXTERNAL_DIRECTORY.should.be.a.String();
       } else {
         should.equal(firebase.utils.FilePath.EXTERNAL_DIRECTORY, null);
       }
 
       // Even on android it may be null, skip if so
-      if (
-        device.getPlatform() === 'android' &&
-        firebase.utils.FilePath.EXTERNAL_STORAGE_DIRECTORY !== null
-      ) {
+      if (Platform.android && firebase.utils.FilePath.EXTERNAL_STORAGE_DIRECTORY !== null) {
         firebase.utils.FilePath.EXTERNAL_STORAGE_DIRECTORY.should.be.a.String();
       } else {
         should.equal(firebase.utils.FilePath.EXTERNAL_STORAGE_DIRECTORY, null);