Skip to content

refactor(ci): testing app with new Jet #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

Salakar
Copy link
Contributor

@Salakar Salakar commented Jul 4, 2024

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 8:42pm

@Salakar Salakar changed the title refactor: remove unnecessary config refactor(ci): testing app with new Jet Jul 4, 2024
@Salakar Salakar force-pushed the refactor-jet-tests branch 2 times, most recently from e7febb3 to 066d1d1 Compare July 4, 2024 20:49
@Salakar Salakar force-pushed the refactor-jet-tests branch from 066d1d1 to 4d6c694 Compare July 4, 2024 21:06
@Salakar Salakar force-pushed the refactor-jet-tests branch from 4d6c694 to 7479de0 Compare July 4, 2024 22:58
@Salakar Salakar force-pushed the refactor-jet-tests branch from 7479de0 to 4418090 Compare July 4, 2024 23:15
@Salakar Salakar force-pushed the refactor-jet-tests branch 2 times, most recently from af703de to 51f34ba Compare July 5, 2024 00:13
@Salakar Salakar force-pushed the refactor-jet-tests branch from 51f34ba to ea48562 Compare July 5, 2024 00:37
@Salakar Salakar force-pushed the refactor-jet-tests branch from ea48562 to 9c1c1b9 Compare July 5, 2024 00:46
@Salakar Salakar force-pushed the refactor-jet-tests branch from 9c1c1b9 to f5e62eb Compare July 5, 2024 02:01
@Salakar Salakar force-pushed the refactor-jet-tests branch from f5e62eb to e80b747 Compare July 5, 2024 02:28
@Salakar Salakar force-pushed the refactor-jet-tests branch from e80b747 to a78d419 Compare July 5, 2024 03:07
@Salakar Salakar force-pushed the refactor-jet-tests branch from 59549df to 685c222 Compare July 7, 2024 20:38
@Salakar Salakar marked this pull request as ready for review July 7, 2024 21:41
@Salakar Salakar merged commit 020e7b8 into feat-other-platforms Jul 7, 2024
18 checks passed
@Salakar Salakar deleted the refactor-jet-tests branch July 7, 2024 21:42
Salakar added a commit that referenced this pull request Jul 9, 2024
@@ -0,0 +1,14 @@
diff --git a/node_modules/@firebase/rules-unit-testing/dist/index.cjs.js b/node_modules/@firebase/rules-unit-testing/dist/index.cjs.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Salakar - any collaboration upstream on this one? Is this upstream-able ? I didn't see a PR in firebase-js-sdk related ...

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants