Skip to content

Conversation

Beat-YT
Copy link
Contributor

@Beat-YT Beat-YT commented Jul 1, 2024

Description

Related issues

fixes #6429

Release Summary

Moved the setter of isHeadless to before the check for rctView that does not exists on react-native-navigation

image

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I sent a remote notification with content-available to true, and then I also opened the app before it shut itself down to test that it does set itself to false as well.
image

p.s: Sorry for the double pull request, I read through the CONTRIBUTING.md a bit too fast 😅

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 9:34am

@Beat-YT
Copy link
Contributor Author

Beat-YT commented Jul 7, 2024

@mikehardy Can you take a look?

Copy link

github-actions bot commented Aug 4, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 4, 2024
@Beat-YT
Copy link
Contributor Author

Beat-YT commented Aug 4, 2024

Well it’s not my fault if no one looks at it

@Beat-YT
Copy link
Contributor Author

Beat-YT commented Aug 4, 2024

@mikehardy you said you’d approve such pull request a while back to fix the issue, can you take a look at this please.

@Beat-YT Beat-YT changed the title fix(messaging, ios): fixed isHeadless for react-native-navigation fix(messaging, ios): fix for isHeadless on react-native-navigation Aug 4, 2024
@Beat-YT Beat-YT changed the title fix(messaging, ios): fix for isHeadless on react-native-navigation fix(messaging, ios): fixed isHeadless for react-native-navigation Aug 4, 2024
@github-actions github-actions bot removed the Stale label Aug 4, 2024
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beat-YT - seems fair enough to me. Need to fix linting failure. There's a script in package.json you need to run: yarn lint:ios:fix. Waiting for CI run to see what else pops up.

@russellwheatley russellwheatley added platform: ios plugin: messaging FCM only - ( messaging() ) - do not use for Notifications Workflow: Pending Merge Waiting on CI or similar blocked: customer-response and removed Workflow: Pending Merge Waiting on CI or similar labels Aug 14, 2024
@Beat-YT
Copy link
Contributor Author

Beat-YT commented Aug 24, 2024

@russellwheatley I have fixed linting failure a you requested.

@Beat-YT
Copy link
Contributor Author

Beat-YT commented Sep 1, 2024

Can you check this out @russellwheatley

@russellwheatley
Copy link
Member

As an FYI; I ran app and tested messages in foreground and background which worked as intended. There are no ways to test this e2e so it was a manual check.

@russellwheatley russellwheatley merged commit 3875cc6 into invertase:main Sep 3, 2024
17 checks passed
@Beat-YT Beat-YT deleted the patch-1 branch September 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention platform: ios plugin: messaging FCM only - ( messaging() ) - do not use for Notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getIsHeadless() always returns false
3 participants