fix(auth): export totp modular types / enable ios sms mfa (w/emulator patch) / add sms mfa to demo #8685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has long irritated me that we could not test SMS MFA on iOS, and I was never certain it worked.
Now we have the ability with local/manual tests to auth against the cloud which allows for MFA testing.
Reviewer note: look at each commit separately, they each have one single idea for easy review
I extended the local TOTP test app to be a general MFA test app with TOTP and/or SMS, and verified that it does work - iOS SMS MFA works against the cloud.
That proved our ios sms mfa issue was emulator-specific, and I was able to quickly localize and patch the error so we can re-enable the e2e test that automatically verifies phone MFA
While doing this I noticed there weren't TOTP exports for modular (and the types weren't unit tested...), and I also thought adding a pointer to the MFA example could help people in docs.
Related issues
Release Summary
fix release, based on the types fix.
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Everything here is backed by tests, and the goal was actually to improve testing of iOS SMS auth to verify it even worked
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter