Skip to content

Conversation

maneesht
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: 1d1ac2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

docs-page bot commented Sep 23, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~225

Documentation is deployed and generated using docs.page.

Copy link

Summary of Changes

Hello @maneesht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the project's dependencies to align with the latest Angular ecosystem, specifically introducing support for Angular version 20. It involves upgrading key Angular packages and @angular/fire to their new major versions, while also ensuring that the packages/angular module maintains compatibility with both Angular v19 and v20 through flexible peer dependency declarations. This change prepares the project for future Angular advancements.

Highlights

  • Angular Core Upgrade: The core Angular development dependency has been updated to version 20.0.0.
  • AngularFire Update: The @angular/fire dependency has been upgraded to version 20.0.0.
  • Peer Dependency Compatibility: The packages/angular module's peer dependencies for Angular packages (common, core, fire, platform-browser-dynamic) have been adjusted to support both Angular v19 and v20, ensuring broader compatibility.
  • Testing Library Update: The @testing-library/angular devDependency has been updated to version 18.0.0.
  • Dependency Removal: Removed @analogjs/vite-plugin-angular and @angular/animations from the devDependencies in packages/angular/package.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies to add support for Angular v20. The changes in package.json and packages/angular/package.json correctly update Angular-related packages and adjust peer dependencies to support both Angular v19 and v20. My review includes one suggestion regarding dependency versioning consistency for @tanstack/angular-query-experimental to prevent potential issues between the development environment and consumer usage.

Copy link
Member

@HassanBahati HassanBahati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

"release": "pnpm build && changeset publish",
"build": "turbo build"
},
"devDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might as well want to bump the angular package version

@cabljac
Copy link
Collaborator

cabljac commented Sep 25, 2025

Closing in favour of #226 so I can manage changesets and the release quickly

@cabljac cabljac closed this Sep 25, 2025
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants